projectstorm / react-diagrams

a super simple, no-nonsense diagramming library written in react that just works

https://projectstorm.cloud/react-diagrams

MIT License

8.58k stars 1.17k forks source link

Fix smart routing selection issue #809

Closed vadimshvetsov closed 3 years ago

vadimshvetsov commented 3 years ago

Checklist

[x] The code has been run through pretty yarn run pretty
[x] The tests pass on CircleCI
[x] You have referenced the issue(s) or other PR(s) this fixes/relates-to
[x] The PR Template has been filled out (see below)
[x] Had a beer/coffee because you are awesome

What?

If you will check smart routing demo you will find out that PathFindingLink becomes selected even when you moving mouse quite far from the path.

screenshot

Why?

The issue lays in DefaultLinkFactory which sets pointer-events: all to the actual path.

How?

I see two possible options for fix it:

Extend PathFindingLinkFactory with generateLinkSegment method for overriding DefaultLinkFactory one
Change path pointer-events style from all to auto in DefaultLinkFactory

I've chosen the second one because see no reason to have pointer-events: all there.

Feel good image:

LOL