projectstorm / react-diagrams

a super simple, no-nonsense diagramming library written in react that just works

https://projectstorm.cloud/react-diagrams

MIT License

8.65k stars 1.17k forks source link

Fixes removeMiddlePoints in LinkModel.ts. #852

Closed ELennard closed 3 years ago

ELennard commented 3 years ago

RemoveMiddlePoints removed the first point from points, while it should not delete the startpoint.

Checklist

[ ] The code has been run through pretty yarn run pretty
[ ] The tests pass on CircleCI
[ ] You have referenced the issue(s) or other PR(s) this fixes/relates-to
[x] The PR Template has been filled out (see below)
[x] Had a beer/coffee because you are awesome

What?

Fixes the removeMiddlePoints function in the LinkModel.

Why?

The removeMiddlePoints function removes the startpoint of a link. The function should only remove points between start and endpoint.

How?

Updated the function to skip the first point.

Feel good image:

LOL