projectstorm / react-diagrams

a super simple, no-nonsense diagramming library written in react that just works

https://projectstorm.cloud/react-diagrams

MIT License

8.51k stars 1.17k forks source link

Fix LabelModel deserialization and react incompatibility with react-dom which refutes Storybook to run #860

Closed vadimshvetsov closed 3 years ago

vadimshvetsov commented 3 years ago

Checklist

[x] The code has been run through pretty yarn run pretty
[x] The tests pass on CircleCI
[x] You have referenced the issue(s) or other PR(s) this fixes/relates-to
[x] The PR Template has been filled out (see below)
[x] Had a beer/coffee because you are awesome

What?

LabelModel can't get deserialized because of #497 issue.
Storybook can't be run from last master commit after building all packages.

Screenshot 2021-07-06 at 16 47 25

Why?

The problem is that this.engine.getCanvas() return undefined on first render.
Because react 16.8 can't work with react-dom 17.

How?

With adding quotation mark to canvas which doesn't fall Closes #497
With update react and react dependant deps to successfully run storybook Closes #858

Feel good image: