projectstorm / react-diagrams

a super simple, no-nonsense diagramming library written in react that just works

https://projectstorm.cloud/react-diagrams

MIT License

8.51k stars 1.17k forks source link

Updated deps to newest version and allow both react 16 and 17 as a peer #860 #861

Closed rkesters closed 2 years ago

rkesters commented 3 years ago

Checklist

[x] The code has been run through pretty yarn run pretty
[x] The tests pass on CircleCI
[x] You have referenced the issue(s) or other PR(s) this fixes/relates-to
[x] The PR Template has been filled out (see below)
[x] Had a beer/coffee because you are awesome

What?

Update deps to support react 16 and react 17. Ensured the devDeps used compatible versions.

Why?

The package does not use anything that is specific to React 17, hence it compatiable with both React 16 and 17.
Out of the box the stroybook package would not run, this had to do we mismatched versions
Use opportunity to update all deps to latest, no breaking changes

How?

made changes to package.json files
updated 1 test file to support jest 27

rkesters commented 3 years ago

@dylanvorster please review.

rkesters commented 3 years ago

@dylanvorster please review.

dylanvorster commented 2 years ago

I am going to rebump all packages though, I think peer deps can include 16, but dev version should be 17