projectstorm / react-diagrams

a super simple, no-nonsense diagramming library written in react that just works

https://projectstorm.cloud/react-diagrams

MIT License

8.51k stars 1.17k forks source link

Fix parent prop on port cloning #870

Closed vadimshvetsov closed 2 years ago

vadimshvetsov commented 2 years ago

Checklist

[x] The code has been run through pretty yarn run pretty
[x] The tests pass on CircleCI
[x] You have referenced the issue(s) or other PR(s) this fixes/relates-to
[x] The PR Template has been filled out (see below)
[x] Had a beer/coffee because you are awesome

What?

Port lost parent on clone

Why?

Because parent wrote to unused parentNode parent instead of parent

How?

Rename prop from parentNode to parent, then on this.getParent() we can get correct parent

Feel good image: