projectstorm / react-diagrams

a super simple, no-nonsense diagramming library written in react that just works

https://projectstorm.cloud/react-diagrams

MIT License

8.51k stars 1.17k forks source link

Fix touch with mouse event bug on selection box usage #871

Closed vadimshvetsov closed 2 years ago

vadimshvetsov commented 2 years ago

Checklist

[x] The code has been run through pretty yarn run pretty
[x] The tests pass on CircleCI
[x] You have referenced the issue(s) or other PR(s) this fixes/relates-to
[x] The PR Template has been filled out (see below)
[x] Had a beer/coffee because you are awesome

What?

Getting Uncaught TypeError: Cannot read properties of undefined (reading 'x') when using SelectionBox

Closes https://github.com/projectstorm/react-diagrams/issues/867

Why?

Because SelectionBox code uses interface as class with instanceof. It's always false.

How?

Remove instanceof usage and rely on object props.

Feel good image: