Closed GaryPan-1515 closed 2 years ago
@dylanvorster Would you take a look at this fix? Thanks!
@dylanvorster Would you take a look at this fix? Thanks!
I fixed zoomToFit method in my project and got same results with one difference: in the end of offsets I got margin * zoomFactor
instead of just margin
Checklist
yarn run pretty
What?
The offset calculation method in the
DiagramEngine.zoomToFitNodes
has problems. This PR fixes the issueBefore
After
Why?
How?
The nodes bounding box's coordinates were not scaled by the zoom factor causing this bug
Feel good image:
(Add your own one below :])