[x] The code has been run through pretty yarn run pretty
[ ] The tests pass on CircleCI
[x] You have referenced the issue(s) or other PR(s) this fixes/relates-to #905
[x] The PR Template has been filled out (see below)
[x] Had a beer because you are awesome
What?
The type for the BaseListener should be updated.
It defines an index signature which enforces the return type for all properties to match the index signature return type.
Nevertheless, the parameters of eventDidFire() and eventWillFire do not match this index type.
There is a small fix to this issue provided in this pr
Checklist
What?
The type for the BaseListener should be updated. It defines an index signature which enforces the return type for all properties to match the index signature return type. Nevertheless, the parameters of eventDidFire() and eventWillFire do not match this index type.
There is a small fix to this issue provided in this pr
Why?
Improves the type system
How?
Usage of union type
Feel good image: