projectstorm / react-diagrams

a super simple, no-nonsense diagramming library written in react that just works

https://projectstorm.cloud/react-diagrams

MIT License

8.46k stars 1.16k forks source link

Correct bug of not deleted link #914

Closed DaSilvaRemi closed 2 years ago

DaSilvaRemi commented 2 years ago

I correct the BUG of the Link doesn't delete when it's not connected to a target port related on issue #895

Checklist

[x] The code has been run through pretty yarn run pretty
[x] The tests pass on CircleCI
[x] You have referenced the issue(s) or other PR(s) this fixes/relates-to
[x] The PR Template has been filled out (see below)
[x] Had a beer/coffee because you are awesome

What?

Correct the bug linkModel.ts because link doesn't delete when you delete a link by it point.

Why?

because the link doesn't delete

How?

delete the property to avoir NULL value

Feel good image:

DaSilvaRemi commented 2 years ago

Pls accept my pull request

DaSilvaRemi commented 2 years ago

@dylanvorster