projectstorm / react-diagrams

a super simple, no-nonsense diagramming library written in react that just works

https://projectstorm.cloud/react-diagrams

MIT License

8.45k stars 1.16k forks source link

Remove hardcode for PointModel in DefaultLinkWidget.tsx #939

Closed ToTheHit closed 1 year ago

ToTheHit commented 2 years ago

Checklist

[x] The code has been run through pretty yarn run pretty
[x] The tests pass on CircleCI
[x] You have referenced the issue(s) or other PR(s) this fixes/relates-to
[x] The PR Template has been filled out (see below)
[x] Had a beer/coffee because you are awesome

What?

Remove hardcode for PointModel in DefaultLinkWidget.tsx (☞ﾟヮﾟ)☞ https://github.com/projectstorm/react-diagrams/issues/938

Why?

Hardcode is bad
In current version of DefaultLinkWidget users can't use custom Points

How?

Simply using the already existing LinkModel method ༼ つ ◕_◕ ༽つ

Feel good image:

dylanvorster commented 2 years ago

click noice

dylanvorster commented 2 years ago

ill try get this merged soon after some testing on my side as well