projectstorm / react-diagrams

a super simple, no-nonsense diagramming library written in react that just works
https://projectstorm.cloud/react-diagrams
MIT License
8.45k stars 1.16k forks source link

Update peer deps in react-canvas-core for working with React 18 #954

Closed vadimshvetsov closed 1 year ago

vadimshvetsov commented 1 year ago

Checklist

Closes #929

What?

Finalize React 18 support

Why?

At react-canvas-core remain 16 || 17 react

How?

Update react-canvas-core

Feel good image:

(Add your own one below :])

image

scottdickerson commented 1 year ago

After we upgraded to @types/react@18 we also had to override this projectstorm type:

/ @ts-ignore
// eslint-disable-next-line implicit-dependencies/no-implicit
import { TransformLayerWidgetProps } from '@projectstorm/react-canvas-core'

// fixes an issue where children prop is removed from React.Component in React v18
// Remove when the React 18 release is official and tested: https://github.com/projectstorm/react-diagrams/releases/tag/v6.7.4
declare module '@projectstorm/react-canvas-core' {
  class TransformLayerWidget extends React.Component<
    PropsWithChildren<TransformLayerWidgetProps>
  > {}
}