search

projectsyn / component-csi-cloudscale

Commodore Component: CSI cloudscale.ch
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

Support configuring different image registries #20

Open simu opened 3 years ago

simu commented 3 years ago

Context

Currently, the component doesn't allow customizing the image registries for the container images used by the component. Being able to configure a different registry can be useful in cases where a registry mirror is required (e.g. to avoid dockerhub pull rate limits).

Alternatives

Deal with intermittent pods in ImagePullBackOff due to pull rate limits.

megian commented 3 years ago

Relates to cloudscale-ch/csi-cloudscale#31.

megian commented 1 year ago

@simu Can we close this issue if favor of #53, where the registry can be overridden?

simu commented 1 year ago

not really, since the component best practices recommend having separate parameters for the Helm chart and container images (cf. https://syn.tools/syn/explanations/commodore-components/container-images.html and https://syn.tools/syn/explanations/commodore-components/helm-charts.html). To ensure we get a single PR which updates both the Helm chart and the container image, we can configure Renovate to group the updates, cf. https://github.com/projectsyn/component-rook-ceph/blob/1a5be5e0a4bbd72659c546ac39eb83d19a284474/renovate.json#L18-L23