Configure ArgoCD to use `Replace=true` to apply CRDs

projectsyn / component-prometheus

Commodore component to wrap kube-prometheus jsonnet library.

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Closed simu closed 2 years ago

simu commented 2 years ago

Fixes #57

[x] PR contains a single logical change (to build a better changelog).
[x] Categorize the PR by setting a good title and adding one of the labels: bug, enhancement, documentation, change, breaking, dependency as they show up in the changelog.
[x] Link this PR to related issues or PRs.

bastjan commented 2 years ago

I guess this is fine because we re-apply the CRDs anyway from ArgoCD? Might be fine https://github.com/argoproj/argo-cd/issues/5704#issuecomment-808355897

simu commented 2 years ago

I guess this is fine because we re-apply the CRDs anyway from ArgoCD? Might be fine argoproj/argo-cd#5704 (comment)

Reading through the linked issues, ArgoCD won't actually replace the CRD resources unless you choose "Force" for a manual sync, see https://github.com/argoproj/gitops-engine/pull/252. We should probably migrate this to use server-side apply once we've upgraded to ArgoCD v2.5 (cf. https://github.com/argoproj/argo-cd/issues/820#issuecomment-1246960210)