search

projectsyn / component-prometheus

Commodore component to wrap kube-prometheus jsonnet library.
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Document the `nodeexporter-remove-mountpropagation` addon #7

Closed bastjan closed 2 years ago

bastjan commented 2 years ago

@TheBigLee What is this used for? I just copied this part around and I'm not sure if it worked before.

Golden says it did not work:

https://github.com/projectsyn/component-syn-kube-prometheus/blob/484df9468ab5d1e6f423f0c88ad60a73188e0d8e/tests/golden/kubernetes_1.21/kubernetes_1.21/kubernetes_1.21/60_node-exporter-daemonset.yaml#L46

_Originally posted by @bastjan in https://github.com/projectsyn/component-syn-kube-prometheus/pull/1#discussion_r876744795_

bastjan commented 2 years ago

The patch did work. Golden tests were not updated

The mountPropagation was most likely removed because /var/lib/docker is at a non standard path on Tanzu and would screw with the file system metrics.

The cleaner way to remove these mount points would be setting filesystemMountPointsExclude correctly: https://github.com/prometheus-operator/kube-prometheus/blob/acd8aeb686ef176a3ac749d76dfcad4694055f65/jsonnet/kube-prometheus/components/node-exporter.libsonnet#L17