Add support for reclass option `ignore_class_notfound_regexp`

projectsyn / reclass-rs

Reimplementation of https://github.com/kapicorp/reclass in Rust with Python bindings through PyO3.

BSD 3-Clause "New" or "Revised" License

8 stars 0 forks source link

Add support for reclass option `ignore_class_notfound_regexp` #101

Closed simu closed 8 months ago

simu commented 8 months ago

The patterns provided in ignore_class_notfound_regexp (which is expected to be a list of strings) are checked when ignore_class_notfound=true.

By default, ignore_class_notfound_regexp is set to the single pattern '.*', so that all missing classes are ignored.

Checklist

[x] The PR has a meaningful title. The title will be used to auto generate the changelog
[x] PR contains a single logical change (to build a better changelog).
[x] Update the documentation.
[x] Update tests.
[x] Categorize the PR by setting a good title and adding one of the labels: bug, enhancement, documentation, change, breaking, dependency, internal as they show up in the changelog

github-actions[bot] commented 8 months ago

Benchmark for 98055f6

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | Reclass::inventory() multi-threaded | 1638.8±125.29µs | 1652.4±127.25µs | +0.83% | | Reclass::inventory() single-threaded | 3.7±0.08ms | **3.6±0.03ms** | **-2.70%** |

simu commented 8 months ago

TODO:

[x] Figure out a reasonable API for users to switch the regex patterns for an existing config (from Python, we probably need to do so via a helper method on Reclass, from Rust, we should think about making the raw fields private, and providing a getter and a setter that recompiles the RegexSet)

github-actions[bot] commented 8 months ago

Benchmark for d56359f

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | Reclass::inventory() multi-threaded | 1593.1±46.66µs | 1630.1±116.42µs | +2.32% | | Reclass::inventory() single-threaded | 3.6±0.03ms | 3.6±0.04ms | 0.00% |

github-actions[bot] commented 8 months ago

Benchmark for 7a8d303

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | Reclass::inventory() multi-threaded | 1611.0±54.02µs | 1645.3±118.73µs | +2.13% | | Reclass::inventory() single-threaded | 3.6±0.03ms | 3.6±0.19ms | 0.00% |