Remove Kapitan patch - Githubissues

projectsyn / reclass-rs

Reimplementation of https://github.com/kapicorp/reclass in Rust with Python bindings through PyO3.

BSD 3-Clause "New" or "Revised" License

8 stars 0 forks source link

Remove Kapitan patch #114

Open simu opened 7 months ago

simu commented 7 months ago

With https://github.com/kapicorp/kapitan/pull/1059 we won't need the Kapitan patch anymore. This PR removes the patch and updates the README to match the new way to use reclass-rs in Kapitan.

Checklist

[x] The PR has a meaningful title. The title will be used to auto generate the changelog
[x] PR contains a single logical change (to build a better changelog).
[x] Update the documentation.
[x] Categorize the PR by setting a good title and adding one of the labels: bug, enhancement, documentation, change, breaking, dependency, internal as they show up in the changelog
[x] Link this PR to related PRs or issues.

github-actions[bot] commented 7 months ago

Benchmark for 3a4307d

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | Reclass::inventory() multi-threaded | 1655.6±109.37µs | 1667.8±148.83µs | +0.74% | | Reclass::inventory() single-threaded | 3.6±0.03ms | 3.6±0.03ms | 0.00% |

github-actions[bot] commented 7 months ago

Benchmark for 1224d00

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | Reclass::inventory() multi-threaded | 1636.3±110.24µs | 1651.0±125.47µs | +0.90% | | Reclass::inventory() single-threaded | **3.6±0.03ms** | 3.7±0.03ms | **+2.78%** |

github-actions[bot] commented 7 months ago

Benchmark for 230746a

Click to view benchmark

| Test | Base | PR | % | |------|--------------|------------------|---| | Reclass::inventory() multi-threaded | 1632.1±110.38µs | 1649.1±117.32µs | +1.04% | | Reclass::inventory() single-threaded | **3.6±0.05ms** | 3.7±0.18ms | **+2.78%** |