search

projectsyn / steward

In-cluster agent for Project Syn
https://docs.syn.tools/steward/index.html
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

ArgoCD v1alpha1 version is deprecated #153

Open megian opened 1 month ago

megian commented 1 month ago

Since the ArgoCD Operator version 0.8.0, the v1beta1 is default. Older objects are going to be converted. Steward restores it and this creates a ping-pong every minute:

W0725 09:06:10.334131       1 warnings.go:70] ArgoCD v1alpha1 version is deprecated and will be converted to v1beta1 automatically. Moving forward, please use v1beta1 as the ArgoCD API version.
DebakelOrakel commented 1 month ago

That should not be the case. Afaik steward does not create ArgoCD CR, it only checks if an ArgoCD is present. The ArgoCD resource is created by component-argocd.

megian commented 1 month ago

@HappyTetrahedron Steward is checking every minute if the ArgoCD Instance on type v1alpha1 object exists https://github.com/projectsyn/steward/blob/9e114fa50dc545074e60a010e869c31c606573fe/pkg/argocd/argocd.go#L58. And it automatically gets converted to v1beta1. So are we sure, the Go implementation can read it on the old API path as well?