projecttacoma / fqm-execution-demo

Apache License 2.0
2 stars 0 forks source link

Refactor to the moon #20

Closed mgramigna closed 3 years ago

mgramigna commented 3 years ago

Requested Cassidy as a meme.

Summary

This PR does a few things, but there are 2 main highlights:

1) Utilize a state management library, recoil, to control the simple states of the app from a top-level. This avoids the need to pass any props to components, and avoids the need for the contexts to require every state variable used by the app. You can read the docs to read more about it, but here is the basic idea:

2) Re-organize the component structure of the app. The folders are now segmented more and clearly labeled for what their purpose is. Here is a diagram of the components fqm-execution-demo

Other Changes

New Behavior

Only new behavior is the loading icons, the rest of the functionality is the same

Testing guidance

Test all features

mgramigna commented 3 years ago

Unhandled Rejection (TypeError): Cannot read property 'find' of undefined is throw for EXM104, denomexcp patient for any calculation

Apparently this bundle has no entires lol. We should fail more safely in this case, but that's in fqm-execution land