search

projecttacoma / fqm-execution-demo

Apache License 2.0
2 stars 0 forks source link

Fqm error handling #29

Closed natjoe4 closed 3 years ago

natjoe4 commented 3 years ago

Summary

Added a try catch statement around all fqm-execution calculator functions to more gracefully handle errors which occur inside fqm-execution and display more helpful error messages. Also added React Router to display results information on a new page and added patient information to results page.

New behavior

-Added more graceful error handling for errors in fqm-execution -Added alerts to display simple error messages in the UI -Disabled summary selection for Gaps in Care reports -Added React Router -Printed results to /results page and navigate to that page upon successful calculation -Printed patient bundle results to results page

Code changes

Changes are in App.tsx, index.tsx, and components/ResultsPage.tsx

Testing guidance

Ensure that the summary button is disabled and individual button is auto-selected when gaps in care is selected. Check that a valid calculation always takes us to a results page and that the routing back to the home page works. Check that errors in fqm-execution (try using EXM-149) will display in an alert and the error log in the console, but will not crash the app entirely.

okeefm commented 3 years ago

I like this! I had one question about the functionality. Do we think that the reset button should clear the error message at the top of the screen?

okeefm commented 3 years ago

Looks like this in app: Screen Shot 2021-07-23 at 13 03 36

natjoe4 commented 3 years ago

One more quick bug that might be worth fixing. When you click the reset button with Gaps in Care output type selected, the Individual report type radio button gets deselected, but the type choice remains greyed out. You can fix it by toggling the output type, but that may not be intuitive to all users.