projecttacoma / fqm-execution-demo

Apache License 2.0
2 stars 0 forks source link

Prioritized reason code #30

Closed eperelli closed 3 years ago

eperelli commented 3 years ago

Summary In fqm-execution-demo, guidance responses with reason details that are not "Missing" or "Present" are prioritized, meaning that they are the first guidance responses listed.

New behavior When running gaps in care, the guidance responses with reason code "Missing" or "Present" are now at the bottom. This was especially important for Bryn's new bundle because guidance responses with other reason codes were at the bottom.

Code changes All code changes were made in DetectedIssueResources.tsx. All of the code to render the accordion remains the same, I just manipulated the guidanceResponseArray so that any guidance responses with reason codes other than "Missing" or "Present" were at the beginning of the array.

Testing guidance I tested this with EX130 although the changes will not be obvious here since the array is already in the desired order. I would still check this to ensure that it is still working. I also tested it with ColorectalCancerScreeningCQM-bundle.json because the array in that bundle is not in the desired order. In addition, using this new bundle meant that I had to upgrade to fqm-execution version 0.5.0 for it to work.

mgramigna commented 3 years ago

So I'm seeing this behavior for the standard dropdown EXM130 bundles, I could be missing something image

The new bundle that we used as a test case does work though. Maybe we can rework the for loop somehow