natjoe4
commented
3 years ago Functionality looks good to me! It looks like the data requirement results are coming up under "patient bundle" on the results page. I'd consider changing the title name to "data requirements output" or something similar. Output also comes out way to the right for all reports run. Not sure if that was changed in this PR, but could be worth looking into.
Summary
A radio button was added to the demo app that allows the user to obtain data requirements output, presented in JSON format.
New behavior
When the user selects the radio button for data requirements, all the patient upload features are grayed out because this output type does not rely on patient bundles - it only depends on measure bundles. The calculation options, report type, and measurement period are also grayed out for data requirements because they are not relevant to this output type. So, when the user selects the data requirements output type, uploads/selects a measure bundle, and clicks the "Calculate" button, the user is brought to a separate screen with the desired JSON output for data requirements.
Code changes
The
src/components/CalculationOptions/OutputType.tsxfile now contains a radio button for the data requirements output. Various components have logic changes to reflect whether the features should be disabled (grayed out) or not, depending on which output type is selected. If the data requirements output type is selected, everything should be grayed out except for the measure bundle upload features. These changes can be found insrc/components/CalculationOptions/CalculationOptions.tsx,src/components/CalculationOptions/MeasurementPeriod.tsx,src/components/Dropdowns/FileImportDropdowns.tsx, andsrc/components/FileUpload/FileUpload.tsx. The filesrc/App.tsxcontains new code to generate the results for the data requirements output type.Testing guidance
Run the fqm-execution demo app and check that previous functionality remains the same for the other output types. Then, try selecting Data Requirements as the output type and choose a measure bundle, either from the respository or as an upload from your local machine. Check that the appropriate JSON output appears on a separate screen. Also check that all the other features (patient upload, calculation options, report type, measurement period) are grayed out and cannot be accessed.
Note: if you upload a patient bundle before selecting the data requirements output type, the uploaded patient bundle will remain on the screen. This is fine for now and is expected. Check that if you upload a patient bundle and then click on the data requirements output type, you cannot try to upload a new patient bundle. You should be able to delete the previously uploaded patient bundle, but you should not be able to select a new one.