projecttacoma / fqm-execution-demo

Apache License 2.0
2 stars 0 forks source link

Disabled HTML for Summary MeasureReports, Disabled Report Type for non-MeasureReports Output Type #34

Closed sarahmcdougall closed 3 years ago

sarahmcdougall commented 3 years ago

Summary

Minor changes were made to the frontend code so that the HTML header no longer appears when the "Summary" Report Type is chosen for Measure Reports. Also, conditional logic was added so that the checkboxes for "Calculation Options" and the radio buttons for "Report Type" are deselected when they are no longer relevant to the selected Output Type.

New behavior

If the user checks the "Calculate SDEs" or "Calculate HTML" checkboxes and then selects an output type/report type that does not allow for the calculation of SDEs or HTML, those checkboxes will be deselected and the HTML headline will not appear on the results page. Similarly, if the user selects an output type that does not require a report type to be selected, the radio buttons for report type will be deselected.

Code changes

These changes are reflected in src/App.tsx by adding an additional condition that checks for an "Individual" report type before calculating the HTML for Measure Reports. Previously, the code would run for "Summary" report type, which caused the demo to believe HTML was selected and made its headline appear on the results page. Changes were made to src/components/CalculationOptions/CalculationOptions.tsx to add logic for the circumstances under which the checkboxes should be allowed to be checked. Lastly, code was added to src/components/CalculationOptions/ReportType.tsx to add logic for the circumstances under which the radio buttons for report type should be allowed to be checked.

Testing guidance

Run the demo app with the EXM130 measure/patient bundle, either through the Connectathon repository or by uploading from your local machine. Try selecting one of the Calculation Options and/or one of the Report Types, and then select an Output Type that does not call for these (good examples include Raw Results and Measure Reports when the Report Type is equal to Summary). Then, for Measure Reports with Report Type of Summary, go through to the results page and check that the HTML headline was not generated.