natjoe4 commented 1 year ago

Summary

Created the first integration testing suite in fqm-execution! This one's for a simple proportion-boolean measure.

New behavior

On npm run build:test-data && npm run test:integration we now have a test suite that runs!

updated makefile with appropriate code paths
added MATGlobalCommonFunctionsFHIR4 to shared CQL directory (is this ok?)
created a getJSONFixture function to more easily pull and type JSON fixtures from patient directories
created proportion-boolean.cql by hand, which eventually gets bundled into proportion-boolean-bundle.json
created patient-denom-bundle, patient-ipp-bundle, and patient-numer-bundle from fqm-testify and added to patients directory.
created exampleValueset1, exampleValueset2, and exampleValueset3, for use across any integration test
updated proportion-boolean-bundle to include custom CQL
filled in proportion-boolean.test.ts
updated .prettierignore to include ecqm-content-r4-2021

run npm run build:test-data
run npm run test:integration
take a closer look at our custom CQL and make sure everything makes sense and is sufficiently simple
can you think of any other tests that make sense for the given test case? positive or negative?

github-actions[bot] commented 1 year ago

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟢	Statements	85.71%	1938/2261
🟡	Branches	73.75%	1711/2320
🟢	Functions	88.72%	346/390
🟢	Lines	85.96%	1868/2173

349 tests passing in 28 suites.

Report generated by 🧪jest coverage report action from 899f4a454b64362ecd03b92b5bffbc7f914adce2

mgramigna commented 1 year ago

I think we're good here