Closed natjoe4 closed 1 year ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π’ | Statements | 84.96% (+0.24% πΌ) |
1983/2334 |
π‘ | Branches | 73.61% (+0.19% πΌ) |
1749/2376 |
π’ | Functions | 87.06% (+0.35% πΌ) |
350/402 |
π’ | Lines | 85.24% (+0.24% πΌ) |
1911/2242 |
359 tests passing in 28 suites.
Report generated by π§ͺjest coverage report action from 2556bea88076fec5e85254a9e9134b7847754bcb
Summary
We've been using 2019-01-01 -> 2019-12-31 as our default interval if one is not passed-in as a calculation option. Now, when one is not provided, we use the effectivePeriod of the Measure, or, when absent, simply pass in no measurement period.
New behavior
data-requirements operations will no longer default to a 2019 measurement period when one is not provided. Instead, the following will happen:
Code changes
getDataRequirements
function to take an additionaleffectivePeriod
argumentextractDataRequirementsMeasurementPeriod
functioncreateIntervalFromEndpoints
functionhasMeasurementPeriodInfo
functionTesting guidance
npm run check
fqm-execution
sh run.sh
test-outputs
and ensure that thedateFilters
all line up with the logic outlined in the new behavior sectiontest-data.zip