projecttacoma / fqm-execution

fqm-execution is a library that allows users to calculate FHIR-based electronic Clinical Quality Measures (eCQMs) and retrieve the results in a variety of formats
https://projecttacoma.github.io/fqm-execution/
Apache License 2.0
18 stars 6 forks source link

(integration tests): fix proportion boolean bundling and allow for force rebuilding #201

Closed mgramigna closed 1 year ago

mgramigna commented 1 year ago

Summary

The existing make target for the proportion boolean integration test didn't work. This was due to the addition of MATGlobalCommonFunctions which included valuesets that ecqm-bundler couldn't resolve.

My solution for this was to just remove this library and uses of it for simplicity. It required deleting one test.

I think one of the reasons that this happened was the git status --porcelain ... command used in the Makefile to only re-build bundles that have a git diff in their main CQL. I added an option to force rebuilding of bundles which will be useful for testing and testing new updates of ecqm bundler.

New behavior

Code changes

Testing guidance

github-actions[bot] commented 1 year ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟒 Statements 85.01% 1990/2341
🟑 Branches 73.68% 1755/2382
🟒 Functions 87.1% 351/403
🟒 Lines 85.3% 1920/2251

Test suite run success

364 tests passing in 28 suites.

Report generated by πŸ§ͺjest coverage report action from 7a9ae7e55a85339f9fc5b36976882c74274ced71