Library data requirements should bypass query filter parsing

[sarahmcdougall]

Summary

Ensures query filter parsing is only performed on measure data requirements and not library data requirements.

New Behavior

When running library data requirements, the detailed query filter parsing will no longer be performed. Library data requirements does not make use of a measurement period because there is no measure, and so it does not make sense to do detailed query filter parsing since a lot of the logic relies on constructing intervals for the (non-existent) measurement period.

Code Changes

• Add check in the conditional ofgetDataRequirements for whether a measurement period is passed in (since it should only be passed in from dataRequirements and not libraryDataRequirements)
• calculateLibraryDataRequirements now omits measurementPeriodStart/measurementPeriodEnd if they are passed in as CLI options (we could change this to throw an error if that is more appropriate)

Testing Guidance

• Run unit tests
• Run library data requirements on the master branch and compare the output to the results on this branch to see the effects of not performing detailed query filter parsing for library data requirements.
  • See the testing guidance in https://github.com/projecttacoma/fqm-execution/pull/181 for an example library bundle and CLI command that can used for running library data requirements.
  • A good way to go about this is to save the output from the master branch to a file, then save the output from this branch to a file, and then use VSCode’s “Select for Compare”/“Compare with Selected” to see the code diff

[github-actions[bot]]

Coverage report

St.:grey_question:	Category	Percentage	Covered / Total
🟢	Statements	85.01%	1990/2341
🟡	Branches	73.65% (-0.03% 🔻)	1755/2383
🟢	Functions	87.1%	351/403
🟢	Lines	85.3%	1920/2251

Show files with reduced coverage 🔻

|

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :----------------------------------------------------------------------------------------------------------------------------------------------------: | :------------------------------------------------------------------------------------- | :--------- | :------------------------------------------------------------- | :-------- | :----- | | 🟢 |

`...` / DataRequirementHelpers.ts

| 82.5% |

81.51% (-0.56% 🔻)

| 75% | 83.33% |

Test suite run success

364 tests passing in 28 suites.

Report generated by 🧪jest coverage report action from e7bb2cfae2f260c0d32c5801cae63615056920d4

[sarahmcdougall]

I want to point out that this code change also turns off queryFilterParsing for regular calculateDataRequirements calls when no measurement period is provided by the user or found in the measure. Is this the expected behavior?

Yes this is expected. Based on this Slack thread there exists at least one measure type that does not require effectivePeriod, but it is unlikely that we will be working with those measures, and if we are, providing the measurement period via the Calculation Options should allow us to still do the query filter parsing. Otherwise, we will bypass the query filter parsing for the measure.