projecttacoma / fqm-execution

fqm-execution is a library that allows users to calculate FHIR-based electronic Clinical Quality Measures (eCQMs) and retrieve the results in a variety of formats

Apache License 2.0

18 stars 6 forks source link

Summary

Fixes #211

New behavior

Before, buildPopulationRelevanceForAllEpisodes() was being called in scenarios where episodeResults is defined, but is an empty array. This caused the highlighting to be incorrect because buildPopulationRelevanceForAllEpisodes had no episode array to work with and therefore returned a masterRelevanceResults array where every entry had a result of false. Now, in ClauseResultsBuilder.ts, we check if results.episodeResults is defined AND has a length greater than 0. As a result, the correct highlighting is shown because it is treated as a normal patient based measure when calculating relevance. We set the precedent of using patient-level logic for this in DetailedResultsBuilder.ts (line 43) so I thought this fix was okay.

Code changes

ClauseResultsBuilder.ts - bug fix and some small grammar fixes

Testing guidance

In the issue, Matt attached a patient and measure bundle for this issue.
Add valuesets to the measure bundle.
npm cli -- detailed -m <path-to-measure-bundle> -b <path-to-patient-bundle> --debug
cd debug/html
Open the clauses HTML and make sure the highlighting is what it is supposed to be (shown in the issue).
Change the patient encounter in the patient bundle to have a status of "finished" rather than "in-progress".
Open the detailed results command again and make sure that highlighting appears, but that it is all green.

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟢	Statements	85.26%	2001/2347
🟡	Branches	73.92% (-0.06% 🔻)	1774/2400
🟢	Functions	87.38%	353/404
🟢	Lines	85.56%	1931/2257

St.^{:grey_question:}