Closed elsaperelli closed 1 year ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π’ | Statements | 85.26% | 2001/2347 |
π‘ | Branches | 73.92% (-0.06% π») |
1774/2400 |
π’ | Functions | 87.38% | 353/404 |
π’ | Lines | 85.56% | 1931/2257 |
371 tests passing in 28 suites.
Report generated by π§ͺjest coverage report action from b4564795b28f1a16374d4b01420a0adadb07a63e
Summary
Fixes #211
New behavior
Before,
buildPopulationRelevanceForAllEpisodes()
was being called in scenarios whereepisodeResults
is defined, but is an empty array. This caused the highlighting to be incorrect becausebuildPopulationRelevanceForAllEpisodes
had no episode array to work with and therefore returned amasterRelevanceResults
array where every entry had a result of false. Now, inClauseResultsBuilder.ts
, we check ifresults.episodeResults
is defined AND has a length greater than 0. As a result, the correct highlighting is shown because it is treated as a normal patient based measure when calculating relevance. We set the precedent of using patient-level logic for this inDetailedResultsBuilder.ts
(line 43) so I thought this fix was okay.Code changes
ClauseResultsBuilder.ts
- bug fix and some small grammar fixesTesting guidance
npm cli -- detailed -m <path-to-measure-bundle> -b <path-to-patient-bundle> --debug
cd debug/html
"finished"
rather than"in-progress"
.