projecttacoma / fqm-execution

fqm-execution is a library that allows users to calculate FHIR-based electronic Clinical Quality Measures (eCQMs) and retrieve the results in a variety of formats

https://projecttacoma.github.io/fqm-execution/

Apache License 2.0

18 stars 6 forks source link

Readme update #220

Closed elsaperelli closed 1 year ago

elsaperelli commented 1 year ago

Summary

Correct use of HL7® FHIR® standard registered trademark.

New behavior

None

Code changes

Change first instance of FHIR to HL7® FHIR® standard. Subsequent uses should be fine as is. Also added a footnote.

Testing guidance

Look at the trademark section in the spec here and make sure I didn't miss anything. Also check the slack thread.
npm run docs should show what the docs page looks like. Make sure the link works there!

github-actions[bot] commented 1 year ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟢	Statements	85.79%	2040/2378
🟡	Branches	74.36%	1821/2449
🟢	Functions	88.02%	360/409
🟢	Lines	86.1%	1969/2287

Test suite run success

382 tests passing in 29 suites.

Report generated by 🧪jest coverage report action from aa8350a6a00d2b4b7474d1f23450358c364c31c0

elsaperelli commented 1 year ago

Because it should be trademarked at least once per page, I think this should also be done in the contributing.md doc, which I can do in my PR.

I also noticed that the basic type (i.e. boolean) links in the Calculation Options section appear to be broken. They're just empty links, and I'm not sure why they're linked at all. I would probably just remove the links for basic types. Is this in scope to fix in this PR, or do you think it should be a different one?

Ooo good idea on adding to to the contributing.md doc- thanks for doing that! Edit: making a ticket for the boolean thing