projecttacoma / fqm-execution

fqm-execution is a library that allows users to calculate FHIR-based electronic Clinical Quality Measures (eCQMs) and retrieve the results in a variety of formats

https://projecttacoma.github.io/fqm-execution/

Apache License 2.0

18 stars 6 forks source link

Add Common Issues description of milli-presi issue to contributing do… #229

Closed lmd59 closed 1 year ago

lmd59 commented 1 year ago

…cument

Summary

Added documentation on time precision to the Contributing docs Common Issues section.

New behavior

None

Code changes

None

Testing guidance

Look at new section here: https://github.com/projecttacoma/fqm-execution/blob/milli-presi/contributing.md#population-results-with-equivalent-datetime-comparisons Are there any issues or clarifications that would be helpful?

github-actions[bot] commented 1 year ago

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟢	Statements	85.79%	2040/2378
🟡	Branches	74.36%	1821/2449
🟢	Functions	88.02%	360/409
🟢	Lines	86.1%	1969/2287

Test suite run success

382 tests passing in 29 suites.

Report generated by 🧪jest coverage report action from 90007aeeae7b582ec2fe3ffa1790608458cb4d8f

lmd59 commented 1 year ago

Just some small nitpicks here. Might it be valuable to add a warning to CQL execution that notifies the user when an Uncertainty is used in this way?

We could... I can add a placeholder ticket for leadership consideration at least.