github-actions[bot]
commented
1 year ago Coverage report
St.:grey_question: |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 85.83% (+0.04% 🔼) |
2047/2385 |
| 🟡 | Branches | 74.45% (+0.09% 🔼) |
1830/2458 |
| 🟢 | Functions | 88.05% (+0.03% 🔼) |
361/410 |
| 🟢 | Lines | 86.14% (+0.04% 🔼) |
1976/2294 |
Test suite run success
383 tests passing in 29 suites.
Report generated by 🧪jest coverage report action from c85df496c603a70872adcee27bd66bd01dfc8bd2
bundles.zip
Summary
Fqm-execution was only pulling in valuesets listed in Library dataRequirements codeFilters, but needs all valueset relatedArtifacts as well to properly supply results. This PR makees updates to ValueSetHelper.ts to retrieve valuesets from VSAC included in the relatedArtifacts of a Library that are not included in the MeasureBundle
New behavior
Calculation on MeasureBundles that do not include all necessary valuesets will now pull in valuesets listed in the
relatedArtifactsproperty of included LibrariesCode changes
Added additional checks to
getMissingDependentValuesetsthat look for valuesets listed inrelatedArtifactsTesting guidance
npm run checknpm run cli -- -p "issuePB.json" -m "issueMB.json" -o --vs-api-key {VSAC_API_KEY}on the attached bundles in master and see that the patient incorrectly evaluates outside of theIPPnpm run cli -- valueSets -m "issueMB.json" -o --vs-api-key {VSAC_API_KEY}and ensure that the output bundle has 26 valueset resources.