projecttacoma / fqm-execution

fqm-execution is a library that allows users to calculate FHIR-based electronic Clinical Quality Measures (eCQMs) and retrieve the results in a variety of formats

Apache License 2.0

17 stars 6 forks source link

Summary

Fixes #262

New behavior

Fixes a bug in the clause coverage percentage calculation.
Clause coverage percentage calculation now captures all relevant clauses and therefore matches the clause coverage highlighting.

Code changes

Before, we were getting allRelevantClauses by finding the clauseResults whose localID and libraryName matched a statement in relevantStatements. This does not capture all of the relevant clauses. We want to find the clauseResults whose statementName and libraryName match statements in relevantStatements. This way all clauses are included in the calculation, not just the root statement clauses like it was doing before.
Additionally, combines some code in generateClauseCoverageHTML that didn't need to be separate.

Testing guidance

npm run check
npm run test:integration
Make sure nothing breaks in the testing.
Test with the bundle and test cases provided in the issue. The clause coverage percentage for this should now be 65.6% and not 100%.
Test some other cases to make sure that the highlighting matches the percentage. Specifically, check that the percentage changes when additional clauses end up being highlighted.

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟢	Statements	85.99% (-0.02% 🔻)	2308/2684
🟡	Branches	73.01% (-0.01% 🔻)	2126/2912
🟢	Functions	89.05% (-0.07% 🔻)	423/475
🟢	Lines	86.33% (-0.02% 🔻)	2230/2583

St.^{:grey_question:}

Category

Percentage

Covered / Total

🟢

Statements

85.99% (-0.02% 🔻)

2308/2684

🟡

Branches

73.01% (-0.01% 🔻)

2126/2912

🟢

Functions

89.05% (-0.07% 🔻)

423/475

🟢

Lines

86.33% (-0.02% 🔻)

2230/2583

Show files with reduced coverage 🔻

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :----------------------------------------------------------------------------------------------------------------------------------------------------: | :------------------------------------------------------------------- | :------------------------------------------------------------- | :------------------------------------------------------------- | :---------------------------------------------------------- | :------------------------------------------------------------- | | 🟢 |

`...` / HTMLBuilder.ts

93.02% (-0.21% 🔻)

76.39% (-0.23% 🔻)

94.59% (-0.41% 🔻)

93.86% (-0.16% 🔻)