Closed elsaperelli closed 10 months ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
🟢 | Statements | 86.58% (+0.09% 🔼) |
2355/2720 |
🟡 | Branches | 73.88% (+0.1% 🔼) |
2189/2963 |
🟢 | Functions | 89.05% | 423/475 |
🟢 | Lines | 86.94% (+0.1% 🔼) |
2276/2618 |
447 tests passing in 31 suites.
Report generated by 🧪jest coverage report action from 928086f47b7bec116aa2af83607e526cc1ee8d87
Summary
Fixes #275 This PR fixes the highlighting issue with the
ValidEncounter
alias in the above issue. This PR does not fix the clause coverage calculation issue and highlighting forreasonCode
, that is being done in this PR in cql-execution.New behavior
Added new handling to
findAllLocalIdsInStatement
to account for aliases that are nested within queries from CQL that was authored using QICore.Code changes
ClauseResultsHelpers.ts
- added branch tofindAllLocalIdsInStatement
to handle query expressions that have a source that is an array with a single value but that value does not have a localId. In this case (that seems to occur when the CQL is authored using QICore), the alias is within thissource[0].expression.scope
. The alias localId is then going to be one less than the localId of the query statement.ClauseResultsHelpers.test.ts
- added a unit test for this new handling that uses CQL query expression authored using QICore.QICoreQuery.cql
/QICoreQuery.json
- test fixtures for the above unit testTesting guidance
npm run check
,npm run test:integration
, run regression tests (all should pass)detailed
calculation on the above issue with a measurement period start of 2024-01-01 and a measurement period end of 2024-12-31 and the debug option off.cd debug/html
).ValidEncounter
should be highlighted (again,reasonCode
will not be highlighted)ValidEncounter
should be highlighted green (reasonCode
will be highlighted red)