projecttacoma / fqm-execution

fqm-execution is a library that allows users to calculate FHIR-based electronic Clinical Quality Measures (eCQMs) and retrieve the results in a variety of formats
https://projecttacoma.github.io/fqm-execution/
Apache License 2.0
17 stars 6 forks source link

Allow for UNHIT clauses to be highlighted as specifically uncovered #282

Closed hossenlopp closed 9 months ago

hossenlopp commented 9 months ago

Summary

Fixes an issue with coverage highlighting where clauses that may have situations with "UNHIT" final results may not be specifically highlighted without coverage and show as covered when they were not. This can happen for any logic that is only relevant when the IPP or DENOM is satisfied. There was no issue with coverage percentage in this situation.

In the case of CMS108, the DENEX related logic would have this bug exhibited when any patients that were testing the IPP fail scenario were included in the set of test patients.

New behavior

Now allows for the UNHIT results to be valid for marking a clause as uncovered instead of inheriting style from the parent clause.

Code changes

HTMLBuilder.ts - Add UNHIT as an option for a clause to be marked uncovered which "whites" out the coverage styling if the parent clause was covered.

Testing guidance

Run coverage calculation with CMS108 and ensure that doNotPerform and the uncovered equality comparisons ~ show as uncovered instead of inheriting the coverage of their parent clauses.

github-actions[bot] commented 9 months ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟒 Statements 86.58% 2355/2720
🟑 Branches
73.83% (-0.05% πŸ”»)
2189/2965
🟒 Functions 89.05% 423/475
🟒 Lines 86.94% 2276/2618
Show files with reduced coverage πŸ”»
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :----------------------------------------------------------------------------------------------------------------------------------------------------: | :------------------------------------------------------------------- | :--------- | :------------------------------------------------------------ | :-------- | :----- | | 🟒 |
`...` / HTMLBuilder.ts
| 92.97% |
77.11% (-1.9% πŸ”»)
| 94.44% | 93.81% |

Test suite run success

447 tests passing in 31 suites.

Report generated by πŸ§ͺjest coverage report action from a465fa2ec08facbb6771aeaee10beea5f4acc2a7