projecttacoma / fqm-execution

fqm-execution is a library that allows users to calculate FHIR-based electronic Clinical Quality Measures (eCQMs) and retrieve the results in a variety of formats
https://projecttacoma.github.io/fqm-execution/
Apache License 2.0
17 stars 6 forks source link

Fix ValueSet reference finder to use proper resource field in relatedArtifacts #286

Closed hossenlopp closed 9 months ago

hossenlopp commented 9 months ago

Summary

Looks for the ValueSet references in the RelatedArtifact resource field. Previously this only looked for the references in the non-existent url field which many measures were using.

New behavior

Looks at resource in addition to url when looking for referenced ValueSet URLs

Code changes

ValueSetHelper.ts - Looks in resource as well.

Testing guidance

Run unit tests. Add ValueSets to a recent measure package that has the fixed references, ensure ValueSets that are referenced in relatedArtifacts only are being pulled in. For example: http://cts.nlm.nih.gov/fhir/ValueSet/2.16.840.1.113762.1.4.1029.206 for the Intensive Care Unit location is not something that will be in the dataRequirements and is only in the relatedArtifacts in CMS190.

github-actions[bot] commented 9 months ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟒 Statements
86.37% (+0.01% πŸ”Ό)
2369/2743
🟑 Branches
73.67% (+0.04% πŸ”Ό)
2194/2978
🟒 Functions 88.89% 424/477
🟒 Lines
86.7% (+0.02% πŸ”Ό)
2289/2640

Test suite run success

449 tests passing in 31 suites.

Report generated by πŸ§ͺjest coverage report action from 8f9621dc3a052e95a85e672babc3bdfe1228d592