Summary

Consolidate helpers, rename files as helpful, and copy functionality or move to shared helpers so that gaps and dataRequirements can function independently without cross referencing each other.

New behavior

None

Code changes

Moved QueryFilterParser and RetrievesHelper to elm helpers
Moved ClauseResultsHelper, rename ReportBuilderFactory
Moved GapsReportBuilder to calculation and rename import to match file name, rename test to GapsReportBuilder.test
Remove GapsReportBuilder dependency from DataRequirementHelpers and replicate dependeny function
Moved detailedFilter functions and codeLookup and flattenFilters to QueryFilterParser
Test and other import updates for all of these

Testing guidance

npm run check
Run integration tests
Test other basic functionality by running gaps and dataRequirements on your favorite test measure, test patient, and test library

Coverage report

St.^{:grey_question:}	Category	Percentage	Covered / Total
🟢	Statements	85.51% (-0.87% 🔻)	2373/2775
🟡	Branches	73.26% (-0.51% 🔻)	2208/3014
🟢	Functions	88.15% (-0.74% 🔻)	424/481
🟢	Lines	85.85% (-0.88% 🔻)	2293/2671

Show new covered files 🐣

St.^{:grey_question:}

`...` / GapsReportBuilder.ts

| 93.66% | 83.91% | 100% | 93.63% | | 🟢 |

`...` / QueryFilterParser.ts

| 86.69% | 80.93% | 97.62% | 86.47% | | 🟡 |

`...` / ClauseResultsHelpers.ts

| 78.1% | 87.86% | 84.62% | 77.78% | | 🟢 |

`...` / RetrievesHelper.ts

| 97.53% | 84.69% | 100% | 97.37% | | 🟢 |

`...` / ReportBuilderFactory.ts

| 100% | 100% | 100% | 100% |

Show files with reduced coverage 🔻

St.^{:grey_question:}

| File | Statements | Branches | Functions | Lines | | :----------------------------------------------------------------------------------------------------------------------------------------------------: | :------------------------------------------------------------------------------------- | :-------------------------------------------------------------- | :------------------------------------------------------------- | :-------------------------------------------------------------- | :-------------------------------------------------------------- | | 🟡 |

`...` / DataRequirementHelpers.ts

66.26% (-18.77% 🔻)

64.81% (-15.5% 🔻)

58.33% (-20.24% 🔻)

67.09% (-18.63% 🔻)

Test suite run success

451 tests passing in 31 suites.

Report generated by 🧪jest coverage report action from caf16687865b8073c222de70d2eb0a7c4d1c08f0

projecttacoma / fqm-execution

Refactor to separate gaps and data requirements #293