projecttacoma / fqm-execution

fqm-execution is a library that allows users to calculate FHIR-based electronic Clinical Quality Measures (eCQMs) and retrieve the results in a variety of formats
https://projecttacoma.github.io/fqm-execution/
Apache License 2.0
18 stars 6 forks source link

Translator 3.7.1 fixes #296

Closed elsaperelli closed 6 months ago

elsaperelli commented 7 months ago

Summary

The cql-to-elm translator was updated recently to version 3.7.1. The major change in this version is that there are now localIds on every statement in the ELM. While this is a good change, it requires us to do some updating in our clause coverage calculation due to workarounds and handling of specific cases that were present in previous translator versions that are now changed.

New behavior

Specifically, this PR adds handling in the findAllLocalIdsInStatement function for any TypeSpecifiers and aliases. Hoss detailed in comments in the code what exactly is being changed.

Code changes

Testing guidance

github-actions[bot] commented 7 months ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟒 Statements
85.46% (-0.05% πŸ”»)
2375/2779
🟑 Branches
73.25% (-0.01% πŸ”»)
2215/3024
🟒 Functions 88.15% 424/481
🟒 Lines
85.79% (-0.05% πŸ”»)
2295/2675
Show files with reduced coverage πŸ”»
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | 🟑 |
`...` / ClauseResultsHelpers.ts
|
77.3% (-0.8% πŸ”»)
|
86.67% (-1.19% πŸ”»)
| 84.62% |
76.98% (-0.8% πŸ”»)
|

Test suite run success

451 tests passing in 31 suites.

Report generated by πŸ§ͺjest coverage report action from 784c804e1b3643a4dd8059eb9e23f93ca5d9f770