Closed elsaperelli closed 6 months ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π’ | Statements | 85.46% (-0.05% π») |
2375/2779 |
π‘ | Branches | 73.25% (-0.01% π») |
2215/3024 |
π’ | Functions | 88.15% | 424/481 |
π’ | Lines | 85.79% (-0.05% π») |
2295/2675 |
451 tests passing in 31 suites.
Report generated by π§ͺjest coverage report action from 784c804e1b3643a4dd8059eb9e23f93ca5d9f770
Summary
The cql-to-elm translator was updated recently to version 3.7.1. The major change in this version is that there are now localIds on every statement in the ELM. While this is a good change, it requires us to do some updating in our clause coverage calculation due to workarounds and handling of specific cases that were present in previous translator versions that are now changed.
New behavior
Specifically, this PR adds handling in the
findAllLocalIdsInStatement
function for any TypeSpecifiers and aliases. Hoss detailed in comments in the code what exactly is being changed.Code changes
src/helpers/ClauseResultsHelpers.ts
- handling infindAllLocalIdsInStatement
that reflects changes made in the translatorTesting guidance
npm run check
--debug
flag and inspect the clause coverage output. The percentage BEFORE the translator changes on the master branch of fqm-execution should be 99.7%, the percentage AFTER the translator changes on the master branch of fqm-execution should be 57.9% and the percentage AFTER the translator changes on this branch should be 99.5%. Note that it is not back to the previous coverage because there are still issues that we are investigating.cql-translation-service
(https://github.com/cqframework/cql-translation-service/pull/40), I was able to run the translation service on his branch and retranslate some of the CQL in the unit tests (test/unit/elm/queries
) and reran the unit tests with no issues. I also did this for the integration tests.cql-translation-service
branch and ecqm-bundler, I was able to retranslate CMS165 using the newest translator version. This branch was able to get coverage back to the same as it was pre translator update.