projecttacoma / fqm-execution

fqm-execution is a library that allows users to calculate FHIR-based electronic Clinical Quality Measures (eCQMs) and retrieve the results in a variety of formats
https://projecttacoma.github.io/fqm-execution/
Apache License 2.0
17 stars 6 forks source link

Sort mustSupports, compare DRs with direct reference codes #300

Closed elsaperelli closed 2 months ago

elsaperelli commented 3 months ago

Summary

While working on data requirements tasking, Hoss and Lauren noticed some issues with the data requirements comparison script now that mustSupports are being incorporated. There were three issues and this addresses two of them: the mustSupport arrays were not being sorted before being compared (i.e. ['code', 'status'] did not equal ['status', 'code'] and data requirements that are not referenced by valueSets but rather through direct reference codes were not being analyzed for mustSupport comparison.

New behavior

Code changes

Testing guidance

github-actions[bot] commented 3 months ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟢 Statements 85.15% 2391/2808
🟡 Branches 73% 2223/3045
🟢 Functions 87.47% 426/487
🟢 Lines 85.46% 2310/2703

Test suite run success

451 tests passing in 31 suites.

Report generated by 🧪jest coverage report action from c53fa0b038b827768a76360558275db6fd10b435