Closed elsaperelli closed 3 months ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
🟢 | Statements | 85.15% (+0.01% 🔼) |
2391/2808 |
🟡 | Branches | 73% | 2223/3045 |
🟢 | Functions | 87.47% | 426/487 |
🟢 | Lines | 85.46% (+0.01% 🔼) |
2310/2703 |
451 tests passing in 31 suites.
Report generated by 🧪jest coverage report action from 8abf1b70a0702ea9ce3f3d56be1b89459b4751c8
Summary
Fixes #297 This PR updates our logic and coverage highlighting to be 508 compliant and also be more resistant to external CSS styling in order to maintain that compliance.
New behavior
Clause coverage highlighting should no longer have a dashed underline for covered clauses.
Code changes
HTMLBuilder.ts
- adds border-botton-width to logic highlighting styles, makes the uncoverage highlighting style separate, adds a flag to the handlebars main function to signal logic highlightingsrc/templates/main.ts
- removesline-height
andborder-bottom-width
from the main template, conditionally adds aline-height
if it's logic highlightingtest/unit/fixtures/html/*
- updated unit test fixtures to reflect styling changesTesting guidance
npm run check
npm run cli -m <path to measure bundle> --patients-directory <path to test cases directory> -o --debug
with the--debug
flag and check the debug outputs (logic highlighting, coverage highlighting, uncoverage highlighting)npm link
in fqm-execution on this branch and thennpm link fqm-execution
in fqm-testify to see how the styling looks in a frontend app