Closed hossenlopp closed 1 month ago
St.:grey_question: |
Category | Percentage | Covered / Total |
---|---|---|---|
π’ | Statements | 85.16% (+0.01% πΌ) |
2393/2810 |
π‘ | Branches | 73.01% (+0.01% πΌ) |
2224/3046 |
π’ | Functions | 87.47% | 426/487 |
π’ | Lines | 85.47% (+0.01% πΌ) |
2312/2705 |
451 tests passing in 31 suites.
Report generated by π§ͺjest coverage report action from 3b13b6986ef62e988d27d1fccbf6a2d88c96982f
Summary
Fixes an issue found in CMS816 bundle from May 2024 connectathon. The ELM in one of the libraries has a Query expression that has the
relationship
field not existent instead of as an empty array. This is allowed by the CQL logical specification. This issue can cause thedataRequirements
operation to fail.New behavior
Only copies the relationship info if it actually exists.
Code changes
src/helpers/elm/QueryFilterParser.ts
- Check of existence of therelationship
field before adding it the list to parse.src/types/ELMTypes.ts
- Update the ELM type for Query to makerelationship
optional.Testing guidance
Ensure CMS861 does not error out when doing
dataRequirement
.