search

projectwife / mtesitoo-android

Android mobile app for the Tesitoo project
6 stars 5 forks source link

When the app is reopened it should show a loading screen while it's logging in and not the Login page with fields #127

Open BassMunkee opened 7 years ago

BassMunkee commented 7 years ago

If a user has logged in before (but currently not in Android memory) and opens the app again, the app should show a 'Logging in..' screen or a 'Loading..' screen.

Currently, it shows the login page with login fields while it is silently trying to log the user.

ptyagicodecamp commented 7 years ago

@BassMunkee : Do you want to take it up as your first bug ? If so, then don't forget to assign this ticket to yourself here at Github and Trello. Thanks !

BassMunkee commented 7 years ago

Sure, will do that. Thanks

BassMunkee commented 6 years ago

Since, ProgressDialog is deprecated in Android Oreo the loading indicator for login and product list should be changed.

Google advices the loading progress to be part of the UI and not blocking the UI. But, the user need not interact with the UI elements (like text field, forgot password) while the app is authenticating the user with the server. So, these elements have to be disabled during login. Currently, most of these elements are handled in the layout file and not in code which will then have to change by adding references to all these elements in code and enabling/disabling them based on the current state.

Since, there is no need to allow the user to interact with these elements can we have a loading indicator as an overlay on top of the screen which blocks the user from interacting with other elements? This will have minimal changes to the existing code and can easily be added to other activities

The current implementation of this looks like the attached file. log in progress

Let me know if I should put this style of loading progress indicator or make it part of the current UI (centre of the screen) while the other elements are disabled. If we should make it part of the UI, how should we do this in Product list page - progress indicator at the top of the list just below the top bar?

Sorry, if the terms I'm using are not the standard Android names for different elements. I hope I'm conveying the point correctly.

ptyagicodecamp commented 6 years ago

This looks fine to me. Yes, for other UIs like ProductListActivity/Fragments, progress should be indicated just below the ActionBar (as recommended by Google)