search

projek-xyz / slim-plates

Render your Slim 3 application views using Plates template engine.
http://www.projek.xyz/slim-plates
MIT License
27 stars 2 forks source link

Code review #1

Closed JoeBengalen closed 9 years ago

JoeBengalen commented 9 years ago

I just read the code a bit an this caught my eye:

https://github.com/feryardiant/slim-plates-view/blob/master/src/Plates.php#L119

Wont that return the return value of write? (which is an int)

Also, where is this $container coming from? https://github.com/feryardiant/slim-plates-view/blob/master/src/Plates.php#L37 The container should be not be there at all. If you want to register the service in the container use the PlatesProvider

feryardiant commented 9 years ago

Hi @JoeBengalen

  1. It tested and return Psr\Http\Message\ResponseInterface as expected
  2. Ah, sorry about that. Previously it's a PlatesProvider before I decided to split it into separated classes.

Regards