projekt0n / github-nvim-theme

GitHub's Neovim themes
MIT License
2.08k stars 105 forks source link

Readme config exemple is wrong! #134

Closed gabrielDpadua21 closed 2 years ago

gabrielDpadua21 commented 2 years ago

This exemplo in readme is not workin because forget the ' in object

Error

" Example config in VimScript " NOTE: Configuration needs to be set BEFORE loading the color scheme withcolorscheme` command let g:github_function_style = "italic" let g:github_sidebars = ["qf", "vista_kind", "terminal", "packer"]

" Change the "hint" color to the "orange" color, and make the "error" color bright red let g:github_colors = { \ 'hint: 'orange', \ 'error': '#ff0000' \ }

" Load the colorscheme colorscheme github_dark `

Work " Example config in VimScript " NOTE: Configuration needs to be set BEFORE loading the color scheme withcolorscheme` command let g:github_function_style = "italic" let g:github_sidebars = ["qf", "vista_kind", "terminal", "packer"]

" Change the "hint" color to the "orange" color, and make the "error" color bright red let g:github_colors = { 'hint': 'orange', 'error': '#ff0000'}

" Load the colorscheme colorscheme github_dark `

ful1e5 commented 2 years ago

I can't see the difference in both configs.

gabrielDpadua21 commented 2 years ago

Missing the ' in hint attribute in github_colors object when you run de config get a error message.

ful1e5 commented 2 years ago

Thanks, @gabrielDpadua21