projekt0n / github-nvim-theme

GitHub's Neovim themes
MIT License
2.08k stars 105 forks source link

Themes seems to be broken #160

Closed nikitastupin closed 1 year ago

nikitastupin commented 2 years ago

Hi 👋 Thank you for the project! I decided to try it but unfortunately faced the problem.

github_light looks like this:

Screenshot 2022-01-22 at 00 19 42

github_dark even worse:

Screenshot 2022-01-22 at 00 20 17
% nvim --version
NVIM v0.6.1
% cat ~/.config/nvim/init.vim 
set number
set relativenumber

call plug#begin()
Plug 'projekt0n/github-nvim-theme'
call plug#end()

colorscheme github_light

I'm running nvim under Ubuntu Server VM.

Any ideas why the theme works that way?

haunt98 commented 2 years ago

I seem to experience the samething. I use neovim in termux over ssh in Terminal.app (macOS)

image

My init.vim

When I use kitty, it seems fine.

image

Maksimka101 commented 2 years ago

Looks like your terminal doesn't support some advanced colours. I had the same problems so I moved from default mac terminal to iterm and now it works fine

negz commented 2 years ago

I have the same problem in the default Mac Terminal.app - but weirdly not when I use tmux inside Terminal.app. 🤔 In Terminal.app TERM=xterm-256color, whereas in tmux TERM=screen-256color. I tried export TERM=screen-256color in "plain" Terminal.app without success.

qinyuhang commented 2 years ago

I have the same issue here. Is this a bug of macOS's default Terminal.app? Any one has an idea of workaround?

UrsaDK commented 1 year ago

To add to what @Maksimka101 has already said: the palette for this colour scheme is defined using hex RGB notations (eg: #e1e4e8), which means that the terminal you use needs to support true colours. The colour palette for Apple's default Terminal.app only supports 256 colours (1, 2, 3, 4). Thus, it simply can not display all the colours defined by this colour scheme.

Why does it works in tmux? - Because tmux is essentially a terminal emulator. It works by translating the features of your actual terminal into an (often different) internal terminal. To put it simply, it duplicates your terminal's ability to draw characters and show colours, but tmux does it using newer libraries. :)

Related notes:

ful1e5 commented 1 year ago

Closing due to inactivity. Can reopen later.