projekt0n / github-nvim-theme

GitHub's Neovim themes
MIT License
2.08k stars 105 forks source link

Error running config: 'group' must be a string with default config #169

Closed tim-hilt closed 2 years ago

tim-hilt commented 2 years ago

This is the full error:

packer.nvim: Error running config for github-nvim-theme: ...packer/start/github-nvim-theme/lua/github-theme/util.lua:115: 'group' must be a string

And this is my configuration for github-nvim-theme:

  use {
    "projekt0n/github-nvim-theme",
    config = function()
      require("github-theme").setup({})
    end
  }
  -- related:
  use {
    "nvim-lualine/lualine.nvim",
    after = "github-nvim-theme",
    requires = { "kyazdani42/nvim-web-devicons", opt = true },
    config = function()
      require("lualine").setup({ options = { theme = "auto" } })
    end
  }

You can take a look at the config in context here.

tim-hilt commented 2 years ago

Update: pinning to commit 4ad832edd70be94 makes the error go away, but now lualine looks funny.

ful1e5 commented 2 years ago

Duplicate of #168

tim-hilt commented 2 years ago

@ful1e5 I’m using the newest Neovim-commit, so that shouldn’t be a duplicate. If you navigate to misc.lua in my config you can see, that I’m already using native augroups. The error even looks different than the one from #168. Also pinning to the commit mentioned in the linked issue didn’t solve the issue for me.

could you reopen the issue please?

tim-hilt commented 2 years ago

Thank you!

ful1e5 commented 2 years ago

Should you try with 508d430f2837bdd6aef0d86bb3092e46b3a9f8c8 ?

tim-hilt commented 2 years ago

I’ll check it out later today. Reverting seems to be a real pity, however holding out native aus should also benefit users, that are not using nightly Neovim.

ful1e5 commented 2 years ago

I will manage to add native autocmds in short with version condition.

tim-hilt commented 2 years ago

That's a good approach. I checked the newest commit and it seems to work again for me, so this issue can be closed.