search

projekt0n / github-nvim-theme

GitHub's Neovim themes
MIT License
2.08k stars 105 forks source link

Override color for selected variant only #176

Closed JoseConseco closed 1 year ago

JoseConseco commented 2 years ago

Hi, I just noticed that when I use color override - eg colors = {bg = "#f5f5f5"}, Then all github-nivm themes will use this white color (obviously I do not want to use white for dark themes). It would be great if we coul override color only for selected theme. Something like

colors = {
   github_light = { bg=  white, comment=xyz },
   github_dark = { ... }
}
ful1e5 commented 1 year ago

I have just completed a major update to the theme's codebase and added the feature you requested. With this update, you can now override colors for specific theme styles or all of them using palettes and specs configs. You can find more information about this in the changelog, which is available from revision 1a96bd061cc30ab2543461d279baf87a68857ffe onwards. To access the changelog, use the command :h github-theme.changelog-23042023 in vim or refer to this discussion.

Thank you for submitting such a great feature request. Although I plan to add more examples and details in the future, I am closing this issue as complete.