search

projekt0n / github-nvim-theme

GitHub's Neovim themes
MIT License
2.07k stars 106 forks source link

Hard to read coc popup menu #205

Closed luisdavim closed 1 year ago

luisdavim commented 1 year ago

coc.nvim has a new custom popup menu with snippet support and this theme might need to be updated to better support it.

The selected element becomes white text on light blue, and that's hard to read due to the low contrast: image

The popup menu background colour should also be slightly different from the editor's background colour. Maybe treating the CoCFloat group as a sidebar could help here.

This seems to be an issue with other themes as well https://github.com/neoclide/coc.nvim/discussions/3999

luisdavim commented 1 year ago

This has been addressed in https://github.com/neoclide/coc.nvim/discussions/3999#discussioncomment-3606286 but it still might be worth looking into and add explicit support for this?

luisdavim commented 1 year ago

The issue seems to be back, to fix it on my end, I've added the following to my configuration:

au ColorScheme * hi! link CocMenuSel PmenuSel
au ColorScheme * hi! link CocPumMenu Pmenu
au ColorScheme * hi! link CocPumVirtualText Comment

I've also opened a PR to fix it for this theme: https://github.com/projekt0n/github-nvim-theme/pull/208