search

projekt0n / github-nvim-theme

GitHub's Neovim themes
MIT License
2.07k stars 106 forks source link

LSP hover popup hard to read #209

Closed TisnKu closed 1 year ago

TisnKu commented 1 year ago

Thanks for the great theme! The background color of lsp hover is the same with buffer editor:

image
ful1e5 commented 1 year ago

@TisnKu During the refactoring process, I resolved the issue but forgot to reference it. To ensure the fix is implemented, please use commit 4d5a4ce881d5d412b7f10f6b2fc7b3531a5138cc on the main branch or a later revision.

TisnKu commented 1 year ago

I just tried and it works.

image

But for some theme the hover is still not very obvious. So I enabled hover border as a workaround.

image
enthusiva commented 1 year ago

Hi. still I could not get the borders shown for the high contrast theme. I use lsp zero nvim package with default recommended preset. I could see the borders for telescope floats but not for lsp floats. Am I missing anything? image

tmillr commented 1 year ago

It's either the highlights, or floating window config (i.e. it might not even be configured to draw a border). I'm not familiar with lsp zero, but by default in neovim, hover and signature popups/floats use the highlight group FloatBorder for their borders. If that plugin is following the defaults, you can do :verb hi FloatBorder to see the highlight definition and visualize what colors are getting used for the border. By using :verb, it should also tell you where that highlight group was last set.

For example:

Screenshot 2023-08-14 at 5 31 54 PM

After running that command, if the fg color is clearly visible in the highlight example (as it is in my screenshot), then you'll need to refer to the config and docs of lsp zero to ensure that these float borders are properly configured. I believe that telescope uses its own custom highlight groups for its float borders, which may or may not link back to FloatBorder.