projekt0n / github-nvim-theme

GitHub's Neovim themes
MIT License
2.07k stars 106 forks source link

Ruby syntax highlighting with tree sitter looks wrong #215

Closed duduribeiro closed 1 year ago

duduribeiro commented 1 year ago

Hey folks 👋

I'm using the color scheme with a ruby code and looks like some parts of the code are not getting highlighted when using tree sitter

See that :name didn't get highlighted 🤔 image

when not using tree sitter, it get highlighted as well image

I think it maybe something on the theme because using other colorscheme works

image

any idea why this happen?

Thanks

duduribeiro commented 1 year ago

also it does not look like the screenshot from the example 😄

image

am I doing something wrong?

mariesavch commented 1 year ago

problem in #214

mariesavch commented 1 year ago

temporarily downgrade treesitter to https://github.com/nvim-treesitter/nvim-treesitter/commit/4cccb6f494eb255b32a290d37c35ca12584c74d0

in packer:

    use {
        "nvim-treesitter/nvim-treesitter",
+      commit = "4cccb6f494eb255b32a290d37c35ca12584c74d0",
        run = function()
            require("nvim-treesitter.install").update { with_sync = true }
        end,
    }
duduribeiro commented 1 year ago

thanks so much for that @idm1try ! it worked perfectly.

The only odd is that the class name is being red instead of purple (like in the print screen from example on readme). See the print screen bellow

image

is this the expected output?

thanks a lot

ful1e5 commented 1 year ago

I have patched the updated tree-sitter highlight group to upstream #222, and I am closing this issue. If the issue persists, please reopen it.