projekt0n / github-nvim-theme

GitHub's Neovim themes
MIT License
2.07k stars 106 forks source link

BufferLine wrong buffer highlighting #218

Closed Orlinky closed 1 year ago

Orlinky commented 1 year ago

Hello,

Recently I updated my neovim plugins after not doing it for about 3 months and to my surprise this broke the unselected buffers highlighting in bufferline.nvim without me changing anything.

Before:

before

After:

after

I looked at the commit history since my last update and this one c306cbd7e8295827921d6e809dcdf1e4d5d092a1 grabbed my attention.

When I remove the line BufferLineBackground = { fg = c.syntax.comment } I always get the initial behaviour regardless if I am only using BufferLineIndicatorSelected = { fg = c.syntax.param } or the original BufferLineIndicatorSelected = { fg = c.blue }

Am I misunderstanding something or was there a mistake with this commit?

My configuration does not have any custom highlighting for bufferline.nvim it always worked out of the box with this colorscheme. I am using Neovim 0.8.1 with iTerm on macOS. My terminal's colorscheme is the one from projekt0n/github-theme-contrib.

jinzhongjia commented 1 year ago

I also meet the problem, and my system is archlinux, neovim version is nightly, and the neovim client neovide

sjdonado commented 1 year ago

Same here! macOS + iTerm2

fgimian commented 1 year ago

I can confirm the same issue here on Windows 11 too.

image

ema2159 commented 1 year ago

This issue still persists

ful1e5 commented 1 year ago

During the refactoring process, I resolved the issue but forgot to reference it. To ensure the fix is implemented, please use commit 4d5a4ce881d5d412b7f10f6b2fc7b3531a5138cc on the main branch or a later revision.

ful1e5 commented 1 year ago

Closing due to inactivity. Can reopen later.