search

projekt0n / github-nvim-theme

GitHub's Neovim themes
MIT License
2.07k stars 106 forks source link

Support new treesitter group names #222

Closed luisiacc closed 1 year ago

luisiacc commented 1 year ago

Hi there, I've translated the old treesitter group names to the new ones so this theme can support new treesitter versions.

This is what it looks like:

image image
ful1e5 commented 1 year ago

Thank you for your dedicated efforts and contributions!

ful1e5 commented 1 year ago

Fixes #214

ful1e5 commented 1 year ago

I'm uncertain if this PR will resolve language-specific issues #220 and #215, but if it doesn't, I will fix them in the refactor. I am writing here to inform you all.

karimdjemai commented 1 year ago

220 seems resolved now, thanks a lot!

AlexXi19 commented 1 year ago

Hi, I still have the same issue as https://github.com/projekt0n/github-nvim-theme/issues/220 and also with a go project but I'm not seeing the changes reflected. I'm new to neovim and I'm using packer, and I've verified that the package is with the latest commit? Thanks for your work on this project!

Github Dark Default in VsCode image Dark Default in nvim Screen Shot 2023-01-03 at 1 55 49 PM

domvo commented 1 year ago

Thanks for the fix and the project in general, it did change things for the better, but I still have a vastly different result compared to what's expected.

Left: nvim, right: vscode

Screenshot 2023-01-04 at 10 19 40

Maybe it's a misconfiguration on my side?